Skip to content

[release-4.16] OCPBUGS-77447: Bump github.com/go-errors/errors to v1.5.1#562

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.16from
adobes1:4.16-fix-vendor
Apr 9, 2026
Merged

[release-4.16] OCPBUGS-77447: Bump github.com/go-errors/errors to v1.5.1#562
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.16from
adobes1:4.16-fix-vendor

Conversation

@adobes1
Copy link
Copy Markdown

@adobes1 adobes1 commented Feb 27, 2026

github.com/go-errors/errors v1.0.1 includes file cover.out which is ignored by .gitignore causing issues during ART's hermetic builds of ose-cluster-baremetal-operator on Konflux.
github.com/go-errors/errors v1.5.1 does not contain this problematic file.

Same approach as in #492

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 27, 2026

@adobes1: This pull request references Jira Issue OCPBUGS-77447, which is invalid:

  • expected dependent Jira Issue OCPBUGS-77446 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

github.com/go-errors/errors v1.0.1 includes file cover.out which is ignored by .gitignore causing issues during ART's hermetic builds of ose-cluster-baremetal-operator on Konflux.
github.com/go-errors/errors v1.5.1 does not contain this problematic file.

Same approach as in #492

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from honza and sadasu February 27, 2026 10:30
@adobes1
Copy link
Copy Markdown
Author

adobes1 commented Mar 4, 2026

/retest

@adobes1
Copy link
Copy Markdown
Author

adobes1 commented Mar 11, 2026

/retest ci/prow/verify-deps

@adobes1
Copy link
Copy Markdown
Author

adobes1 commented Mar 11, 2026

/test ci/prow/verify-deps

@adobes1
Copy link
Copy Markdown
Author

adobes1 commented Mar 11, 2026

/retest

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 25, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 354415f0-1c04-4e24-9f28-171d6d44c5f1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fgallott
Copy link
Copy Markdown

fgallott commented Mar 25, 2026

/test lint

1 similar comment
@fgallott
Copy link
Copy Markdown

fgallott commented Mar 26, 2026

/test lint

@fgallott
fix unit tests
c74d43c 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@fgallott
Copy link
Copy Markdown

fgallott commented Mar 26, 2026

/test e2e-agnostic-ovn
/test e2e-metal-ipi-serial-ipv4

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 26, 2026

@adobes1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dtantsur
Copy link
Copy Markdown
Member

dtantsur commented Apr 7, 2026

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 7, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adobes1, dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2026
@hroyrh
Copy link
Copy Markdown
Contributor

hroyrh commented Apr 9, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2026
@jupierce jupierce added verified Signifies that the PR passed pre-merge verification criteria jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 9, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit c6f6632 into openshift:release-4.16 Apr 9, 2026
13 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 9, 2026

@adobes1: Jira Issue Verification Checks: Jira Issue OCPBUGS-77447
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77447 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

github.com/go-errors/errors v1.0.1 includes file cover.out which is ignored by .gitignore causing issues during ART's hermetic builds of ose-cluster-baremetal-operator on Konflux.
github.com/go-errors/errors v1.5.1 does not contain this problematic file.

Same approach as in #492

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fgallott fgallott deleted the 4.16-fix-vendor branch April 10, 2026 07:22
@fgallott fgallott mentioned this pull request Apr 10, 2026
Merged
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Apr 10, 2026

Fix included in release 4.16.0-0.nightly-2026-04-10-025757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@honza honza Awaiting requested review from honza

@sadasu sadasu Awaiting requested review from sadasu

Assignees

@hroyrh hroyrh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@adobes1 @openshift-ci-robot @fgallott @dtantsur @hroyrh @openshift-merge-robot @jupierce